Wireshark-commits: [Wireshark-commits] master d3df2e5: On UN*X, <arpa/inet.h> suffices for struct i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 8 Apr 2014 08:23:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d3df2e588bc6febb5b2d414ad040ede903ef4c85
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d3df2e5 by Guy Harris (guy@xxxxxxxxxxxx):

    On UN*X, <arpa/inet.h> suffices for struct in_addr and in_addr_t.
    
    So don't pull in <netinet/in.h>.  Also, avoid <sys/types.h> in
    packet-dcom.c.
    
    While we're at it, do *not* assume that pinfo->src or pinfo->dst are
    IPv4 addresses.
    
    Change-Id: I5fc8e859780a8d863aaf6e90a21a7039cabae0e6
    Reviewed-on: https://code.wireshark.org/review/1006
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  abbdcd8   Fix warning found by -Wunused-const-variable (Clang 3.5)
    adds  d3df2e5   On UN*X, <arpa/inet.h> suffices for struct in_addr and in_addr_t.


Summary of changes:
 epan/dissectors/packet-dcom.c  |   11 ++---------
 epan/dissectors/packet-fcdns.c |    4 ----
 epan/dissectors/packet-lbm.h   |    3 ---
 epan/dissectors/packet-lbmc.c  |    5 -----
 epan/dissectors/packet-lbmr.c  |    8 ++++----
 epan/dissectors/packet-lbtrm.c |    6 ++----
 6 files changed, 8 insertions(+), 29 deletions(-)