Wireshark-commits: [Wireshark-commits] master e60ed4f: IANA assigned port number 6653 to OpenFlow.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Apr 2014 17:21:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e60ed4fc304c05bb8063d23c8a4032b62f9fadb7
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e60ed4f by Francesco Fondelli (francesco.fondelli@xxxxxxxxx):

    IANA assigned port number 6653 to OpenFlow.  However, applications
    (e.g. opendaylight, nox, openvswitch, etc) still use legacy port
    numbers.  The most common are 6633 and 6634.  This patch adds a
    simple heuristic logic and uses the current uint preference as
    additional input.  In most cases no user intervention is needed and
    OpenFlow is automatically detected/dissected.
    
    Change-Id: Iebf09b7b870efe9d52421b9acc238208d25d4565
    Signed-off-by: Francesco Fondelli <francesco.fondelli@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/921
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  5647301   [Automatic manuf, services and enterprise-numbers update for 2014-04-06]
    adds  e60ed4f   IANA assigned port number 6653 to OpenFlow.  However, applications (e.g. opendaylight, nox, openvswitch, etc) still use legacy port numbers.  The most common are 6633 and 6634.  This patch adds a simple heuristic logic and uses the current uint preference as additional input.  In most cases no user intervention is needed and OpenFlow is automatically detected/dissected.


Summary of changes:
 AUTHORS                           |    1 +
 epan/dissectors/packet-openflow.c |   54 +++++++++++++++++++++++++++++--------
 2 files changed, 44 insertions(+), 11 deletions(-)