Wireshark · Wireshark-commits: [Wireshark-commits] master 914cbc2: Fix checkApis perl script false positive proto_tree_add with ENC

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=914cbc2f3c7dc54ecd4f441d1d300516cef02e58
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

914cbc2 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Fix checkApis perl script false positive proto_tree_add with ENC_*
    
    In epan/proto.c in function proto_tree_add_split_bits_crumb, the
    proto_tree_add_text function is called with one of its arguments
    using ENC_BIG_ENDIAN, but it's not an argument for proto_tree_add_text
    itself but instead a function being called inside it. checkAPIs.pl
    tries to avoid this in check_proto_tree_add_XXX_encoding, by removing
    parenthesis arguments, but in this acse there are newlines between
    the arguments, causing the regex to not catch them. This commit
    fixes the regex.
    
    Change-Id: I70ef79d5436ba2ec04ffdc3d9939c7aa2cdf6a1f
    Reviewed-on: https://code.wireshark.org/review/902
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e7b3eff   Fix tshark.c to pass checkAPIs script
    adds  914cbc2   Fix checkApis perl script false positive proto_tree_add with ENC_*


Summary of changes:
 tools/checkAPIs.pl |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)