Wireshark · Wireshark-commits: [Wireshark-commits] master a8e9637: Fix two bugs and do misc other minor changes;

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a8e963709063ff7b7b36f319fa2827e9be0af2e9
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a8e9637 by Bill Meier (wmeier@xxxxxxxxxxx):

    Fix two bugs and do misc other minor changes;
    
    Bugs fixed:
     - col_...() should not be called under 'if (tree)';
     - proto_reg_handoff_pdc(): pdc tcp.port preference change was handled incorrectly;
    
    Minor changes:
    - Move proto_reg_handoff...() to the end of the file as per convention;
    - new_register_dissector...() call not needed;
    - Remove some unneeded initializers;
    - 'xxx++' ==> 'xxx += 1' in a few instances;
    - widen a few variables (guint? ==> guint);
    - Add XXX comment about possible simplification of the code;
    - Remove unneeded #include <epan/reassemble.h>;
    - Reformat hf[] entries for readability;
    - Do whitespace changes;
    
    Change-Id: Ib9224f0c6392a45c19656a63bbac97fbaf3acc08
    Reviewed-on: https://code.wireshark.org/review/900
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    Tested-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  a72dc7a   Fix expert_...() calls to not be under 'if (tree)';Do other minor changes;
    adds  a8e9637   Fix two bugs and do misc other minor changes;


Summary of changes:
 epan/dissectors/packet-pdc.c |  408 +++++++++++++++++++++++++-----------------
 1 file changed, 240 insertions(+), 168 deletions(-)