Wireshark-commits: [Wireshark-commits] master 650ed5f: packet-osc dissector bug fix of path validit
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 31 Mar 2014 06:43:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=650ed5f249561ce65d10ea6141557b3adea3329e
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

650ed5f by Hanspeter Portner (dev@xxxxxxxxxxxxxxxxxxxxxxxxx):

    packet-osc dissector bug fix of path validity func
    
    - 'is_valid_path' function has been corrected
    - an OSC path is valid if:
     - it consists of printable characters only
     - does not contain ' ' and '#'
    - characters '*' ',' '?' '[' ']' '{' '}' are valid, but have special meaning at the receiving end (used for pattern matching)
    
    Change-Id: I4ff4308d0955da2ef377d606b7778819b97754a0
    Reviewed-on: https://code.wireshark.org/review/868
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  550e315   Fix fuzz-test.sh '-b' option so it works again; Do some other tools/*test*.sh changes
    adds  650ed5f   packet-osc dissector bug fix of path validity func


Summary of changes:
 epan/dissectors/packet-osc.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)