Wireshark-commits: [Wireshark-commits] master d5ddfed: clean up the png dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 26 Mar 2014 22:16:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d5ddfed512913b82ab0d97403ccd6aacd4941735
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d5ddfed by Martin Kaiser (wireshark@xxxxxxxxx):

    clean up the png dissector
    
    use value_string instead of our own data type
    read the type string in one go
    
    Change-Id: I115c99c4636540702c1fd301f09a92a0dd466fcd
    Reviewed-on: https://code.wireshark.org/review/838
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  436100c   use the correct png chunk len the parameter for proto_tree_add_text() is the length, not the end offset
    adds  d5ddfed   clean up the png dissector


Summary of changes:
 epan/dissectors/file-png.c |  133 +++++++++++++++++++++++---------------------
 1 file changed, 69 insertions(+), 64 deletions(-)