Wireshark-commits: [Wireshark-commits] master a04f610: Add debug printing functions for conversatio
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 21 Mar 2014 05:16:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a04f610989400f76beaa7709b0e7fa1bce2109a7
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a04f610 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Add debug printing functions for conversations, sip, sdp, rtp
    
    There have been enough gnarly bus in sip/sdp/rtp that it needs
    to have good debug printing. Using a debugger isn't good enough
    because there's interaction across multiple frames and it's too
    hard to follow what's going on without real printed data history.
    
    Change-Id: Ifb5bb1fb580be81f988569ece79d238a9c030c34
    Reviewed-on: https://code.wireshark.org/review/688
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9c5f199   Fix bug 9909 Buildbot crash - but only to stop the crashing
    adds  a04f610   Add debug printing functions for conversations, sip, sdp, rtp


Summary of changes:
 epan/Makefile.common         |    1 +
 epan/conversation.c          |   54 +++++++
 epan/conversation_debug.h    |   47 ++++++
 epan/dissectors/packet-rtp.c |   71 ++++++++-
 epan/dissectors/packet-sdp.c |  332 +++++++++++++++++++++++++++++++++++++++---
 epan/dissectors/packet-sip.c |   45 ++++++
 6 files changed, 522 insertions(+), 28 deletions(-)
 create mode 100644 epan/conversation_debug.h