Wireshark-commits: [Wireshark-commits] master c8a98f3: Fix lua file testsuite not working and weak
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8a98f37ec300b522a732c349a7d3f0c17b7168d
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
c8a98f3 by Hadriel Kaplan (hadrielk@xxxxxxxxx):
Fix lua file testsuite not working and weak heuristic readers not being registered
The testsuite for Lua file reader/writer uses the acme_file.lua script to
generate a pcapng file from an Acme sipmsg.log file. It then compares the
tshark verbose output of this new pcapng file to a sip.pcapng file in
the test/captures directory that was previously made. Unfortunately, the
acme_file.lua script generates a timestamp based on local system timezone,
rather than UTC, so the testsuite fails if not run in the EST timezone where
the sip.pcapng file was originally made. This has now been fixed.
Also, trying to register new weak heuristic readers fails because the GArray
is terminated with a NULL-based row without Glib knowing about that. So this
commit changes it to let Glib handle the NULL-terminated row, so that appending
takes it into account automatically.
Change-Id: I037ce1cfbda03585b3a1e159df78ff8ebb41fc32
Reviewed-on: https://code.wireshark.org/review/741
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Actions performed:
from a68e3a4 Wiretap: Add support for Android Logcat
adds c8a98f3 Fix lua file testsuite not working and weak heuristic readers not being registered
Summary of changes:
test/captures/sip.pcapng | Bin 3696 -> 3696 bytes
test/lua/acme_file.lua | 19 +++++++++++++++++++
test/lua/pcap_file.lua | 4 ++--
test/suite-wslua.sh | 19 ++++++++++---------
wiretap/file_access.c | 3 +--
5 files changed, 32 insertions(+), 13 deletions(-)
