Wireshark · Wireshark-commits: [Wireshark-commits] master f02b888: Fix two bugs & do various other changes.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f02b8880205fdec8500cb6a2a4a7ff1e3080ab28
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f02b888 by Bill Meier (wmeier@xxxxxxxxxxx):

    Fix two bugs & do various other changes.
    
    Bugs fixed:
    - Catch exceptions during heuristics test so that the sequence of
      dissector heuristics tests is not terminated abnormally;
      (Prevents incorrect tshark "one-pass" dissection);
    - Comment out registration of heuristic for TCP; TCP dissection
      requires different code than for UDP. ("XXX: ToDo" added)
    
    Misc:
    - Create/use two extended value_strings;
    - "UL" is not needed as a modifier for several constants;
    - Remove some unneeded initializers;
    - Localize some variables;
    - Remove unneeded '#include <stdlib.h>
    - Do some whitespace changes.
    
    Change-Id: Ida11cb6b26911c0032155fde7491dd2a6f136c34
    Reviewed-on: https://code.wireshark.org/review/650
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    Tested-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  740ec32   Ensure there's no exception during the initial heuristics test.
    adds  f02b888   Fix two bugs & do various other changes.


Summary of changes:
 epan/dissectors/packet-osc.c |  178 +++++++++++++++++++++++-------------------
 1 file changed, 99 insertions(+), 79 deletions(-)