Wireshark-commits: [Wireshark-commits] master-1.10 e856d75: Always have WS_DLL_PUBLIC include "exte
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Mar 2014 03:21:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e856d75fbc248f4f08084b69dc1c51851ca83183
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

e856d75 by Guy Harris (guy@xxxxxxxxxxxx):

    Always have WS_DLL_PUBLIC include "extern".
    
    This may fix some issues Albert Chin found on Solaris, which might be
    due to variables being defined, not just declared, in header files due
    to the lack of "extern".
    
    Done by backporting some changes from the trunk, but without renaming
    WS_DLL_PUBLIC_NOEXTERN to WS_DLL_PUBLIC_DEF, so that we don't have to
    change any other files.
    
    We also pick up comments from those changes.
    
    Change-Id: I6b0b9ee59a2379fca3279a17774f637b26f0b48d
    Reviewed-on: https://code.wireshark.org/review/611
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8a21c7a   Replace one more g_memmove with memmove, add a cast to make the Lua stuff compile.
    adds  e856d75   Always have WS_DLL_PUBLIC include "extern".


Summary of changes:
 ws_symbol_export.h |   85 +++++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 74 insertions(+), 11 deletions(-)