Wireshark-commits: [Wireshark-commits] master 784808c: PDCP LTE: various fixes related to security
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Mar 2014 13:12:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=784808ca861611c86f0a6455114006cc28b969b1
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

784808c by Martin Mathieson (martin.r.mathieson@xxxxxxxxxxxxxx):

    PDCP LTE: various fixes related to security handling
    
    - fixes the wrap multiplier (for COUNT) for 12-bit sequence numbers
    - fixes dissection of non-ciphered IP payloads
    - adds a way for private protocols to set keys. The ueid->key lookup is now broken out into a separate function, and these settings are used in preference to the UAT ones
    
    Change-Id: I723307df3ee20425897b82beb9b431a0860075cf
    Reviewed-on: https://code.wireshark.org/review/583
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  b996e8a   Add two more casts to satisfy OSX10.6 buildbot
    adds  784808c   PDCP LTE: various fixes related to security handling


Summary of changes:
 epan/dissectors/packet-pdcp-lte.c |  219 +++++++++++++++++++++++++------------
 epan/dissectors/packet-pdcp-lte.h |    6 +
 2 files changed, 153 insertions(+), 72 deletions(-)