Wireshark-commits: [Wireshark-commits] master 93a59e7: Open Sound Control dissector.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 6 Mar 2014 09:21:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=93a59e74c38fe2039c30ef91f9a857912bd790cc
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

93a59e7 by Hanspeter Portner (dev@xxxxxxxxxxxxxxxxxxxxxxxxx):

    Open Sound Control dissector.
    
    Dissector for specification at http://opensoundcontrol.org/spec-1_0.
    
    - use value_string
    - add integer oferflow protection
    - remove trailing white space
    - add capture file to bug tracker: Bug 9837
    - fix warnings by tools/fix-encodings-args.pl
    - make use of VALS
    - dissect MIDI controller messages separately
    
    Change-Id: Iab0dc01d4bf1c08eac175b6af1dd07809090c35a
    Reviewed-on: https://code.wireshark.org/review/454
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  c9dd46c   Bluetooth: Make Source/Destination BD_ADDRs and names filterable
    adds  93a59e7   Open Sound Control dissector.


Summary of changes:
 epan/CMakeLists.txt             |    1 +
 epan/dissectors/Makefile.common |    1 +
 epan/dissectors/packet-osc.c    |  848 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 850 insertions(+)
 create mode 100644 epan/dissectors/packet-osc.c