Wireshark-commits: [Wireshark-commits] master-1.10 447c45a: Disable IPv4 checksum verfification to
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 4 Mar 2014 18:18:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=447c45a341124f091543cbe7ad6d6872a041f6ba
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

447c45a by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Disable IPv4 checksum verfification to match TCP and UDP.
    
    Offloading seems to be very common nowadays and having this option
    enabled by default generates a lot of false positives. Suggested by
    Laura Chappell.
    
    Change-Id: I285f218efb3c9f164d8ad7a6d6de8270e442ffff
    Reviewed-on: https://code.wireshark.org/review/426
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 104a6edd1fb703c5c2319c893720df86f8c9a9e7)
    Reviewed-on: https://code.wireshark.org/review/470
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  31187b1   Switch to "rc" instead of "pre" to match our tags.
    adds  447c45a   Disable IPv4 checksum verfification to match TCP and UDP.


Summary of changes:
 epan/dissectors/packet-ip.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)