Wireshark-commits: [Wireshark-commits] master 54cf849: Add the PPID for 3GPP Pua. Move the (unregis
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 1 Mar 2014 21:17:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=54cf849419a3537d065428181ea4717997fc597b
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

54cf849 by Jeff Morriss (morriss@xxxxxxxxxxx):

    Add the PPID for 3GPP Pua.  Move the (unregistered) M2TP PPID into that dissector.
    
    Also put a note in sctpppids.h saying that only IANA-registered PPIDs should go
    in that file.  Inspired by the rejection of
    https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4332
    
    Change-Id: I763aad7d1b69e9d36c798061473438ce3cb66ca1
    Reviewed-on: https://code.wireshark.org/review/434
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  79ef36a   Fix some scan-build warnings.
    adds  54cf849   Add the PPID for 3GPP Pua.  Move the (unregistered) M2TP PPID into that dissector.


Summary of changes:
 epan/dissectors/packet-m2tp.c |    5 ++---
 epan/sctpppids.h              |   12 +++++++-----
 2 files changed, 9 insertions(+), 8 deletions(-)