Wireshark-commits: [Wireshark-commits] master-1.10 e635d3f: Have git-compare-abis build in a sub-su
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 1 Mar 2014 00:41:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e635d3f0f2bc1f1909553294a6488b6bd947f82d
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

e635d3f by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Have git-compare-abis build in a sub-sub-subdirectory.
    
    We have a lot of relative includes which apparently weren't updated
    correctly when we moved the gtk directory to ui/gtk. For example,
    ui/gtk/about_dlg.c has
    
    The Autotools Makefile adds "-I../.." to the include path, which means
    we end up including the current, top-level version_info.h instead of the
    one in the compare-abis build directory.
    
    Change-Id: I9df83857fc9f7d87a3b79d5b4da08d5e41625e4c
    Reviewed-on: https://code.wireshark.org/review/436
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  d8075e7   Don't mix emem and glib memory and init routines.
    adds  e635d3f   Have git-compare-abis build in a sub-sub-subdirectory.


Summary of changes:
 tools/git-compare-abis.sh |   15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)