Wireshark-commits: [Wireshark-commits] master c826191: Fix coverity warnings for all wslua files. (
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 27 Feb 2014 21:23:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c826191be02132251a9bd7cdaa44647b24bfce95
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c826191 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Fix coverity warnings for all wslua files. (redux)
    
    This fixes/addresses all the coverity warnings shown by
    the buildbots. (I hope)
    
    Change-Id: Ic2722df97c577d274e3cf3f0cbdca1902edde047
    Reviewed-on: https://code.wireshark.org/review/423
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  c875dc8   Fix dumpcap.c: Assigned value is garbage or undefined (clang analyzer)
    adds  c826191   Fix coverity warnings for all wslua files. (redux)


Summary of changes:
 epan/wslua/init_wslua.c      |    2 +-
 epan/wslua/wslua.h           |   53 +++++++++---
 epan/wslua/wslua_dumper.c    |   27 +++++--
 epan/wslua/wslua_field.c     |   28 ++++---
 epan/wslua/wslua_gui.c       |   99 ++++++++++++++++++-----
 epan/wslua/wslua_int64.c     |   43 +++++-----
 epan/wslua/wslua_internals.c |    4 +-
 epan/wslua/wslua_listener.c  |    5 +-
 epan/wslua/wslua_pinfo.c     |   24 ++++--
 epan/wslua/wslua_proto.c     |  184 +++++++++++++++++++++++++++---------------
 epan/wslua/wslua_struct.c    |   10 ++-
 epan/wslua/wslua_tree.c      |    8 +-
 epan/wslua/wslua_tvb.c       |   36 ++++++---
 epan/wslua/wslua_util.c      |   31 +++++--
 14 files changed, 383 insertions(+), 171 deletions(-)