Wireshark-commits: [Wireshark-commits] master 9815a25: Fix crash when exporting dissection summarie
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 25 Feb 2014 09:08:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9815a25971dba21b36145d5798164d3acbc8f9d0
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9815a25 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix crash when exporting dissection summaries to a CSV file.
    
    The while loop in question ends with tmp_str being NULL; the next loop
    processes the same string, so you have to set tmp_str to csv_str before
    looping.
    
    Fix some comments while we're at it.
    
    Change-Id: I69dd7dc276e0cb11226eceee7921be87e3cc7534
    Reviewed-on: https://code.wireshark.org/review/352
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  92a369e   Remove a few wrong use of tvb_get_string()
    adds  9815a25   Fix crash when exporting dissection summaries to a CSV file.


Summary of changes:
 epan/print.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)