Wireshark-commits: [Wireshark-commits] master 88c34ec: Fix Called function pointer is null (null de
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Feb 2014 16:43:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=88c34ec6c817d4175643408dcb5e537b5f068602
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

88c34ec by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    Fix Called function pointer is null (null dereference) found by Clang
    
    ../../asn1/h248/packet-h248-template.c:1222:31: warning: Value stored to 'prop' is never read
            if (!prop->dissector) prop = &no_param;
    
    Change-Id: I6d380fbb5fef9dc548385b0b470aea1cb3c34df1
    Reviewed-on: https://code.wireshark.org/review/301
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  cfeae2f   Fix clang warning regarding null pointer use in packet-sip.c.
    adds  88c34ec   Fix Called function pointer is null (null dereference) found by Clang


Summary of changes:
 asn1/h248/packet-h248-template.c |    5 ++---
 epan/dissectors/packet-h248.c    |   11 +++++------
 2 files changed, 7 insertions(+), 9 deletions(-)