Wireshark-commits: [Wireshark-commits] master 22149c5: TVB API deprecations and cleanup
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 22 Feb 2014 15:02:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=22149c5523a77e642ec13d12064b2ccef29e51fb
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

22149c5 by Evan Huus (eapache@xxxxxxxxx):

    TVB API deprecations and cleanup
    
    - rename tvb_length and similar to tvb_captured_length and similar; leave
      #defines in place for backwards-compat, but mark them clearly as deprecated in
      code comments and in checkAPI
    - remove tvb_get_string as C code and just leave a #define in place for
      backwards-compat; mark it clearly as deprecated in code comment and checkAPI
    - update READMEs and sample dissector for all of the above
    - while in the neighbourhood, make checkAPI skip (and warn) for missing files
      instead of bailing on the whole check, so subsequent files still get checked
    
    Change-Id: I32fc437896ca86ca73e9b49d5f50400adf8ec5ad
    Reviewed-on: https://code.wireshark.org/review/311
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  00cc94b   Add bug 9492.
    adds  22149c5   TVB API deprecations and cleanup


Summary of changes:
 doc/README.dissector     |   21 ++++++---------------
 doc/packet-PROTOABBREV.c |    6 +++---
 epan/tvbuff.c            |   30 ++++++++++--------------------
 epan/tvbuff.h            |   42 +++++++++++++++++++++++++-----------------
 tools/checkAPIs.pl       |   21 +++++++++++++++------
 5 files changed, 59 insertions(+), 61 deletions(-)