Wireshark-commits: [Wireshark-commits] master 95190e4: EPL + openSAFETY: Better handling of guint i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 21 Feb 2014 16:45:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=95190e4bd6aaab1250c38de0c0c6c1f7e5cfb0f8
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

95190e4 by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    EPL + openSAFETY: Better handling of guint in EPL
    
     This is a permanent solution for bug #9786. guint overflows
     are now prevented, and the remaining length is queried from
     tvb and taken into consideration.
    
     As a side-effect, the fix brought up two bugs in the openSAFETY
     dissector, which where fixed as well.
    
     Upd: Remove stdio.h and fix one encoding error found by
     fix-encoding-args.pl
    
    Change-Id: Ic2d478a8ea15b0bcfd2536a074c217daf610fe08
    Reviewed-on: https://code.wireshark.org/review/291
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  caaac7e   Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
    adds  95190e4   EPL + openSAFETY: Better handling of guint in EPL


Summary of changes:
 epan/dissectors/packet-epl.c        |   73 +++++++++++++++++++++++------------
 epan/dissectors/packet-opensafety.c |   37 ++++++++----------
 2 files changed, 65 insertions(+), 45 deletions(-)