Wireshark-commits: [Wireshark-commits] master 0548a7d: Simplify/improve handling of FQDN field in v
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 19 Feb 2014 18:30:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0548a7d549d2203c7f1ed4d74e7bc5091a3f9d5a
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0548a7d by Bill Meier (wmeier@xxxxxxxxxxx):

    Simplify/improve handling of FQDN field in various options; Fix some minor bugs.
    
    Details:
    - Use dhcpv6_domain() to handle dissection of certain FQDN fields:
      + OPTION_AFTR_NAME:           Don't use get_dns_name(); It allows "compression"
                                     which is not valid forthis field.
      + OPTION_CCCV6_IETF_PROV_SRV: Replace use of swap_field_length_with_char();
                                    Fix bug which caused invalid "expert" message.
      + OPTION_CCCV6_KRB_REALM:     Remove validation; replace use of swap_field_length_with_char().
    
    - Allow filtering for each different FQDN field (rather than using a generic "dhcpv6.domain"
       for the various FQDN fields).
    
    - Fix some bugs in the display of the dissection for NTP_SERVER_OPTION;
    - Add some "XXX ToDo" comments.
    - Add some comments as the to specific RFC for certain options;
    - Note that RFC 4075 is now "deprecated";
    - CL-SP-CANN-DHCP-Reg: version I10 is the latest as  Feb 2014.
    
    Change-Id: I82edafb8293b71037b84629406ce609f9a835f04
    Reviewed-on: https://code.wireshark.org/review/257
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    Tested-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  0d244ee   Remove code which dissects CableLabs options 17.2170.3 thru 17.2170.9  inasmuch as these options don't exist per the spec.
    adds  0548a7d   Simplify/improve handling of FQDN field in various options; Fix some minor bugs.


Summary of changes:
 epan/dissectors/packet-dhcpv6.c |  304 +++++++++++++++++----------------------
 1 file changed, 131 insertions(+), 173 deletions(-)
 mode change 100644 => 100755 epan/dissectors/packet-dhcpv6.c