Wireshark-commits: [Wireshark-commits] master-1.10 8e4e30f: Fix Bug 9728 'Lua: ProtoField.bool() VA
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 14 Feb 2014 13:52:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8e4e30f615293b42d14a687ae0db986458942d10
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

8e4e30f by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Fix Bug 9728 'Lua: ProtoField.bool() VALUESTRING argument is not optional but was supposed to be'
    
    Similar to bug 9725 and ProtoField.new(), the way the VALUESTRING argument is being checked
    in the code for ProtoField.bool() ends up making it non-optional.  This patch fixes that,
    along with some minor API documentation fixes (text).
    
    This is a backport for change-id Iadb9a8ace9c5514fc623d882301fe16b637fe4ce
    
    Change-Id: Ic60375f3e0ad7c7a8887dce7ffbd946f0a9d80b5
    Reviewed-on: https://code.wireshark.org/review/209
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  b826cb9   Fix Bug 9725 'Lua: ProtoField.new() is buggy'
    adds  8e4e30f   Fix Bug 9728 'Lua: ProtoField.bool() VALUESTRING argument is not optional but was supposed to be'


Summary of changes:
 epan/wslua/wslua_proto.c |    8 ++++++--
 epan/wslua/wslua_tree.c  |   30 ++++++++++++++++++++++--------
 epan/wslua/wslua_tvb.c   |    8 ++++----
 3 files changed, 32 insertions(+), 14 deletions(-)