Wireshark · Wireshark-commits: [Wireshark-commits] master-1.10 b826cb9: Fix Bug 9725 'Lua: ProtoField.new() is buggy'

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b826cb9da886d135fdb07439e31dc1ea496911ab
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

b826cb9 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Fix Bug 9725 'Lua: ProtoField.new() is buggy'
    
    Using ProtoField.new() is dicey.  Many of the optional arguments don't properly check the lua stack - they call lua_isnil() for their index number, instead of lua_gettop() to see the stack size.  lua_isnil() may return false in such cases.
    
    Change-Id: I83ca1e5fc34e71ec35899adbedabcee69571b9fe
    Reviewed-on: https://code.wireshark.org/review/118
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/207
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  00caebf   Fix the host entry.
    adds  b826cb9   Fix Bug 9725 'Lua: ProtoField.new() is buggy'


Summary of changes:
 epan/wslua/wslua_proto.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)