Wireshark-commits: [Wireshark-commits] master 217f9fd: Fix Bug 9728 'Lua: ProtoField.bool() VALUEST
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Feb 2014 19:40:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=217f9fd0d9f2d6a9084da3fc945cce001414eea3
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

217f9fd by Hadriel Kaplan (hadrielk@xxxxxxxxx):

      Fix Bug 9728 'Lua: ProtoField.bool() VALUESTRING argument is not optional but was supposed to be'
      
      Similar to bug 9725 and ProtoField.new(), the way the VALUESTRING argument is being checked
      in the code for ProtoField.bool() ends up making it non-optional.  This patch fixes that,
      along with some minor API documentation fixes (text).
      
      Change-Id: Iadb9a8ace9c5514fc623d882301fe16b637fe4ce
      Reviewed-on: https://code.wireshark.org/review/125
      Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
      Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
      

Actions performed:

      from  373bf9b   Parse SIP sec-mechanism
      adds  217f9fd   Fix Bug 9728 'Lua: ProtoField.bool() VALUESTRING argument is not optional but was supposed to be'


Summary of changes:
 epan/wslua/wslua_proto.c |    8 ++++++--
 epan/wslua/wslua_tree.c  |   30 ++++++++++++++++++++++--------
 epan/wslua/wslua_tvb.c   |   10 +++++-----
 3 files changed, 33 insertions(+), 15 deletions(-)