Wireshark-commits: [Wireshark-commits] rev 54716: / /trunk-1.8/epan/dissectors/: packet-cell_broadc
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=54716
User: guy
Date: 2014/01/13 08:03 PM
Log:
Copy over r54714 from trunk:
------------------------------------------------------------------------
r54714 | guy | 2014-01-13 11:49:12 -0800 (Mon, 13 Jan 2014) | 17 lines
In a source file that defines external functions, the header file that
declares the functions must be included, in order to make sure the
declarations match the function signature. Make it so.
They *didn't* match; fix that.
Do *not* use 16-bit tvbuff offsets; there is no advantage to that (and,
in fact, 32-bit arithmetic may be easier on some platforms), and it has
the disadvantage that you're more likely to have the offset overflow.
dissect_cbs_serial_number() returns the new offset, not the length of
the item it dissected; don't add its return value to the offset, set the
offset to its return value.
Make dissect_cbs_message_identifier() return the new offset as well, for
consistency, and don't add *its* return value to the offset.
Directory: /trunk-1.8/epan/dissectors/
Changes Path Action
+11 -8 packet-cell_broadcast.c Modified
+8 -4 packet-cell_broadcast.h Modified
