Wireshark · Wireshark-commits: [Wireshark-commits] rev 50500: /trunk/ui/cli/ /trunk/ui/cli/: tap-iostat.c

[guy@xxxxxxxxxxxxx]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=50500

User: guy
Date: 2013/07/11 02:40 AM

Log:
 Get rid of an unused variable.
 
 Don't nest g_strconcat() calls: g_strconcat(a, g_strconcat(b, c, NULL), NULL)
 is equivalent to g_strconcat(a, b, c, NULL).  (And g_strconcat(b, c) is
 incorrect - you need a NULL at the end of the list.)
 
 Checking whether a pointer is "> 0" is useful only in platform-dependent
 situations or if you're doing a really greasy hack such as stuffing a
 flag into the uppermost bit of the pointer; the test should just check
 whether the pointer is null or not.

Directory: /trunk/ui/cli/
  Changes    Path            Action
  +4 -3      tap-iostat.c    Modified