Wireshark · Wireshark-commits: [Wireshark-commits] rev 50184: /trunk/epan/wmem/ /trunk/epan/wmem/: wmem_test.c

[eapache@xxxxxxxxxxxxx]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=50184

User: eapache
Date: 2013/06/26 08:44 PM

Log:
 *sigh*
 
 From the comment above wmem_tree_insert32_array():
  * If you use ...32_array() calls you MUST make sure that every single node
  * you add to a specific tree always has a key of exactly the same number of
  * keylen words or things will most likely crash. Or at least that every single
  * item that sits behind the same top level node always have exactly the same
  * number of words.
 
 So clearly generating thousands of keys with random lengths while testing is
 going to cause problems. Generate a set of random lengths, then use those
 lengths consistently (but still generating random keys of those lengths).
 
 Should hopefully fix the intermittent build-bot failures.
 
 (unfortunately this does not manifest nicely, and I cannot see an easy way to
 assert it so that we catch other people trying to use different-length key
 subtrees)

Directory: /trunk/epan/wmem/
  Changes    Path           Action
  +5 -3      wmem_test.c    Modified