Wireshark-commits: [Wireshark-commits] rev 50073: /trunk/ /trunk/epan/dissectors/: packet-dap.c pac
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: eapache@xxxxxxxxxxxxx
Date: Thu, 20 Jun 2013 06:26:05 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=50073

User: eapache
Date: 2013/06/19 11:26 PM

Log:
 Back out some of the wmem conversions (r50063 and r50057).
 
 These dissectors allocate ephemeral or seasonal memory in UAT callbacks, which
 really makes no sense because UAT callbacks can occur when there is no packet or
 file in scope, making this effectively a leak if the user is fiddling with their
 UAT and never opens a capture.
 
 Emem let you get away with this, wmem forces an assertion. Back out the changes
 so that the UATs are usable until the code can be properly fixed to not use
 out-of-scope allocators.

Directory: /trunk/epan/dissectors/
  Changes    Path             Action
  +1 -1      packet-dap.c     Modified
  +10 -10    packet-ldap.c    Modified
  +3 -3      packet-pres.c    Modified
  +31 -31    packet-snmp.c    Modified

Directory: /trunk/asn1/ldap/
  Changes    Path                      Action
  +10 -10    packet-ldap-template.c    Modified

Directory: /trunk/asn1/pres/
  Changes    Path                      Action
  +3 -3      packet-pres-template.c    Modified

Directory: /trunk/asn1/snmp/
  Changes    Path                      Action
  +31 -31    packet-snmp-template.c    Modified