Wireshark-commits: [Wireshark-commits] rev 49387: /trunk/ /trunk/ui/gtk/: follow_ssl.c follow_strea
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=49387
User: eapache
Date: 2013/05/17 02:50 PM
Log:
From Robert Bullen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8643
When a TCP segment contains the end of two or more SSL PDUs, the TCP reassembly
code passes that segment up to the SSL dissector multiple times--one for each
SSL PDU. The SSL dissector queues the packet for SSL tap listeners each time it
is invoked. Therefore a single packet can be processed by SSL tap listeners
multiple times. But the tap data that the SSL dissector sends to its tap
listeners is a linked list of all PDUs in the packet.
The SSL tap listener responsible for populating the Follow SSL Stream dialog
did not account for the possibility of seeing a packet multiple times. As a
result, it would process the entire linked list of PDUs each time it received a
packet, and that would result in some SSL PDUs showing up two or more times in
the dialog.
This patch fixes the described bug. It also implements a few slight
improvements in closely related code. See bugzilla for details.
Directory: /trunk/ui/gtk/
Changes Path Action
+116 -106 follow_ssl.c Modified
+17 -17 follow_stream.c Modified
+1 -1 follow_stream.h Modified
Directory: /trunk/
Changes Path Action
+1 -1 AUTHORS Modified
