Wireshark-commits: [Wireshark-commits] rev 48744: /trunk/epan/dissectors/ /trunk/epan/dissectors/:
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: etxrab@xxxxxxxxxxxxx
Date: Fri, 05 Apr 2013 05:20:42 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=48744

User: etxrab
Date: 2013/04/04 10:20 PM

Log:
 From Cal Turney:
 Patch 45480 introduced the following check: 
 
 "tvb_ensure_bytes_exist(tvb, offset, neo ? neo : *bcp - ((unsigned)offset + 1));:     
 
 When the last entry in the directory listing is processed, 'neo' the next entry offset is zero so bcp is checked. The 'bcp' variable is set to the remaining reported bytes in the tvb.  Subtracting the current offset +1 from *bcp usually produces a negative result and causes the error.
 
 Removed "- ((unsigned)offset + 1)" and added "CHECK_BYTE_COUNT_SUBR(4);"
 
 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8549

Directory: /trunk/epan/dissectors/
  Changes    Path            Action
  +12 -6     packet-smb.c    Modified