Wireshark · Wireshark-commits: [Wireshark-commits] rev 46672: /trunk-1.8/epan/dissectors/ /trunk-1.8/epan/dissectors/: packet-fc.c

[etxrab@xxxxxxxxxxxxx]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=46672

User: etxrab
Date: 2012/12/21 05:58 AM

Log:
 Copy over:
 Revision 46464 - 
 Bugfix FCP lun request/response tracking.
 
 This works towards bug 3209 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3209) by at least satisfying the layer under SCSI.  All of the dissectors that feed into SCSI seem to have similar "lun tracking" issues, so I think a more general solution may be needed to fix the bug "right"
 
 #BACKPORT
 
 --------------------------------------------------------------------------------
 Revision 46324 - Introduce, and start using, TVB_SET_ADDRESS() and TVB_SET_ADDRESS_HF().  They
 are like the non-TVB versions except that they take a TVB and an offset
 instead of (frequently) a pointer into the TVB.
 
 Calling tvb_get_ptr() before modifying the rest of the fields should help fix
 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7960 (though I can't
 reproduce that problem).
 
 
 Replace a bunch of calls like:
 
 SET_ADDRESS(..., AT_XXX, length, tvb_get_ptr(tvb, offset, length));
 
 with:
 
 TVB_SET_ADDRESS(..., AT_XXX, tvb, offset, length);

Directory: /trunk-1.8/epan/dissectors/
  Changes    Path            Action
  +3 -4      packet-fc.c     Modified
  +1 -2      packet-fc.h     Modified
  +68 -31    packet-fcp.c    Modified