Wireshark · Wireshark-commits: [Wireshark-commits] rev 46083: / /trunk/ui/gtk/: capture_dlg.c capture_if_details_dlg_win32.c captur

[etxrab@xxxxxxxxxxxxx]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=46083

User: etxrab
Date: 2012/11/19 12:07 PM

Log:
 From Mike Garratt:
 Friendly Names for interfaces on Windows
 
 Notes on the changes the patch covers:
 * if_info_t struct: addition of friendly_name
 * Dumpcap Interface list format changes:
   + Win32: "dumpcap -D" shows friendly_name in place of descript if known
   + All: machine interface "dumpcap -D -Z none" includes friendly_name in the
 list in addition to the existing parameters
 * interface_options struct: addition of console_display_name
   + When an interface name is displayed in a console, it will typically be the
 console_display_name (instead of name). 
   + console_display_name is used as the basis of the autogenerated temp
 filenames
   + console_display_name is typically set to the friendly_name if known,
 otherwise it is set to the interface name
 * Enhancements to capture_opts_add_iface_opt() (the function which process -i
 options).
   + Can now specify the interface using its name and friendly_name
   + Interface name matching is case insenstive
   + Name matching first attempts exact matching, then falls back to prefix
 matching
     (e.g. dumpcap -i local)
   + Validates interface names, instead of blindly sending them off to
 winpcap/libpcap
   + Interface specification by number is still supported.
 * capture_opts_trim_iface() has been refactored:
   + Instead of repeating a decent chunk of the cost in
 capture_opts_add_iface_opt(), it calls capture_opts_trim_iface() to specify the
 interface.
 * introduction of capture_win_ifnames.[ch] (windows only code)
   + Implements static function GetInterfaceFriendlyNameFromDeviceGuid() - a
 windows version independant function to convert an interface guid into its
 friendly name.  Uses published api functions on windows vista and higher, but
 falls back to unpublished API functions on older windows releases.
   + void get_windows_interface_friendlyname(/* IN */ char
 *interface_devicename, /* OUT */char **interface_friendlyname); - extracts the
 GUID from the interface_devicename, then uses
 GetInterfaceFriendlyNameFromDeviceGuid() to do the resolution
 * Auto temp filename generation:
   + Now uses wireshark_pcapng_* or  wireshark_pcap_* depending on file format
   + Basis temp filename format on console_display_name
   + Win32: if console_display_name is a windows interface guid, extracts
 numbers from GUID here (instead of in interface option processing) 
 
 GUI CHANGES:
 * Dialog that displays when you click the "Manage Interfaces" button (within
 Capture Options dialog) has been renamed from "Add new interfaces" to
 "Interface Management"
 * ui/gtk/capture_dlg.c: new_interfaces_w variable renamed to
 interface_management_w
 * Win32: Local Interfaces tab on Interface Management dialog, shows includes
 friendly name as far left column
 * Interface Management dialog defaults to larger size on win32 - so it fits
 without resizing local interfaces tab
 * Interface Management dialog now saves preferences when you click the apply
 button (local hidden interfaces was not persisting across restarts)
 * Tweaks: "Interface Details" dialog (Interface list->Capture Interfaces ->
 Details):
   + "Friendly Name" renamed to "NDIS Friendly Name"
   + Added "OS Friendly Name" to the top of the list
 * Win32: The "Capture Interfaces" dialog now shows the friendly name instead of
 device guid
 * Welcome screen:
   + The height of the interface list scrollbox dynamically adjusts & updates to
 the number visible interfaces.
     Up to 10 interfaces can be listed without a scroll bar, the minimum height
 is for 2 interfaces. 
   + Win32: now shows just the Friendly Name if known - in place of
 "Interfacename_Guid:(Description)"

Directory: /trunk/ui/gtk/
  Changes    Path                              Action
  +86 -58    capture_dlg.c                     Modified
  +12 -2     capture_if_details_dlg_win32.c    Modified
  +24 -12    capture_if_dlg.c                  Modified
  +47 -14    main_welcome.c                    Modified

Directory: /trunk/
  Changes    Path                     Action
  +1 -1      CMakeLists.txt           Modified
  +2 -0      Makefile.am              Modified
  +11 -0     capture-pcap-util.c      Modified
  +6 -4      capture_ifinfo.c         Modified
  +2 -1      capture_ifinfo.h         Modified
  +124 -96   capture_opts.c           Modified
  +3 -1      capture_opts.h           Modified


(6 files not shown)