Wireshark · Wireshark-commits: [Wireshark-commits] rev 43908: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-ftp.c

[martinm@xxxxxxxxxxxxx]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=43908

User: martinm
Date: 2012/07/21 09:44 PM

Log:
 Calling tvb_format_text() for binary data segments (c1400 bytes) was
 *very* slow (in a profiled run where FTP data is carried over LTE
 MAC/RLC/PDCP/IP/TCP, this one function call was 20% of overall runtime).
 
 Have limited to call to ITEM_LABEL_LENGTH, as that is all that
 will be displayed anyway.  As per comment, I'm not convinced that doing
 this for binary FTP data segments is worthwhile at all.  It doesn't
 even display as hex.

Directory: /trunk/epan/dissectors/
  Changes    Path            Action
  +6 -3      packet-ftp.c    Modified