Wireshark-commits: [Wireshark-commits] rev 35408: /trunk/epan/dissectors/ /trunk/epan/dissectors/:
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: guy@xxxxxxxxxxxxx
Date: Thu, 06 Jan 2011 22:52:43 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=35408

User: guy
Date: 2011/01/06 02:52 PM

Log:
 Don't use g_warning() - either you have a dissector bug, and should use
 one of the macros to report that, or you have a problem with the packet,
 in which case you should note that in the protocol tree, or you have
 something you don't understand, in which case you should dissect
 whatever of it you do understand and put something appropriate, if
 possible, into the protocol tree for the rest.
 
 (And, if the length isn't right, there's not much you can do about it -
 you have to trust the length, and manage to fail somewhere else.)

Directory: /trunk/epan/dissectors/
  Changes    Path             Action
  +14 -3     packet-icmp.c    Modified