Wireshark-commits: [Wireshark-commits] rev 33065: /trunk/epan/ /trunk/epan/: sigcomp-udvm.c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: guy@xxxxxxxxxxxxx
Date: Thu, 03 Jun 2010 01:22:24 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=33065

User: guy
Date: 2010/06/02 06:22 PM

Log:
 Sorry, I forgot that 8.6. UDVM Cycles says
 
 	Note that the number of UDVM cycles MUST NOT be increased if a
 	request for additional compressed data fails.
 
 so we *shouldn't* increase the cycle count further when
 SIGCOMP_INSTR_INPUT_BYTES fails.  That does *NOT* of course, mean that
 we shouldn't increase the cycle count by 1 for a failed INPUT-BYTES
 instruction - that would leave UDVM vulnerable to infinite loops (as per
 bug 4826), and I *really* doubt that was their intent; presumably, it
 means it should not be increased *by the number of cycles for the
 additional data*:
 
 	Additionally, if the UDVM successfully requests n bits of
 	compressed data using one of the INPUT instructions then the
 	number of available UDVM cycles is increased by n *
 	cycles_per_bit once the instruction has been executed.
 
 if the attempt to get that additional data fails.

Directory: /trunk/epan/
  Changes    Path              Action
  +0 -1      sigcomp-udvm.c    Modified