Wireshark-commits: [Wireshark-commits] rev 31249: /trunk/ /trunk/epan/: proto.c proto.h /trunk/gtk/
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: guy@xxxxxxxxxxxxx
Date: Sat, 12 Dec 2009 03:15:31 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=31249

User: guy
Date: 2009/12/11 07:15 PM

Log:
 Rename BASE_STRUCTURE_RESET to BASE_DISPLAY_E_MASK, to clarify that it's
 a mask to select the base_display_e value from a display field in a
 header_field_info structure.
 
 Never select that value by masking out the BASE_RANGE_STRING flag bit,
 as that won't continue to work if more flag bits, or other bitfields,
 are added.  Instead, mask with BASE_DISPLAY_E_MASK.
 
 Note that the base_display_e value and BASE_RANGE_STRING flag are only
 for integral field types, and clarify what BASE_DISPLAY_E_MASK is.
 
 Give at least one of the reasons why hiding protocol fields is not
 considered a good idea.

Directory: /trunk/epan/
  Changes    Path          Action
  +10 -12    proto.c       Modified
  +20 -12    proto.h       Modified

Directory: /trunk/gtk/
  Changes    Path                  Action
  +1 -1      dfilter_expr_dlg.c    Modified