Wireshark-commits: [Wireshark-commits] rev 29102: /trunk-1.2/ /trunk-1.2/epan/dfilter/: semcheck.c
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=29102
User: gerald
Date: 2009/07/15 12:22 PM
Log:
Copy over revisions from the trunk:
------------------------------------------------------------------------
r28923 | gerald | 2009-07-02 12:50:35 -0700 (Thu, 02 Jul 2009) | 2 lines
Changed paths:
M /trunk/epan/Makefile.nmake
M /trunk/epan/libwireshark.def
mkstemp cleanups.
------------------------------------------------------------------------
r28931 | wmeier | 2009-07-02 18:11:23 -0700 (Thu, 02 Jul 2009) | 12 lines
Changed paths:
M /trunk/epan/dfilter/semcheck.c
M /trunk/gtk/dfilter_expr_dlg.c
From Kovarththanan Rajaratnam: Fixes for bug #3536
(plus some additional changes by me).
Handle BASE_RANGE_STRING display types properly
We always treat header field info strings as value_string's undiscriminated.
However, if the header field info display is marked as BASE_RANGE_STRING, we
need to treat them as range_string's. This wasn't properly handled in the
filter expression dialog and in the filter toolbar which would cause a crash
upon referencing any fields marked as BASE_RANGE_STRING.
------------------------------------------------------------------------
r28937 | wmeier | 2009-07-03 09:03:02 -0700 (Fri, 03 Jul 2009) | 29 lines
Changed paths:
M /trunk/epan/dissectors/packet-radius.c
M /trunk/epan/radius_dict.l
From: Tobias Witek: Fix processing of radius 'vendor specific attributes'
In the RADIUS dissector, the function radius_register_avp_dissector() registers
vendors that are not already present in the dictionary hash-table. As far as I
can see, there are two problems with this:
1. The function does not set the number of type/length octets and the has_flags
variable for that AVP, which is required to correctly decode AVP/VSA values
2. In some situations, the function is called _before_ radius_load_dictionary()
is called (for example for the vendor 3GPP (ID: 10415))
Therefore, all vendor entries that are created by calling
radius_register_avp_dissector() leave their type_octets and length_octets un-initialized,
which causes incorrect decoding.
[Result: Radius dissector displays messages such as:
"Malformed Packet: RADIUS" and "Error/Malformed: Malformed Packet(Exception occurred)"]
The attached patch fixes this problem by assuming that the dictionary knows the
'ground truth' about the type/length octet and the has_flags information and allows it to
overwrite these values even for vendors that have already been loaded.
Also: (from Bill Meier): set the type/length octet and the has_flags variables to default
"standard" values (1,1,FALSE) in radius_register_avp_dissector().
Fixes Bug #3651 (and Bug #3635).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3651
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3635
------------------------------------------------------------------------
r28939 | etxrab | 2009-07-04 08:15:51 -0700 (Sat, 04 Jul 2009) | 3 lines
Changed paths:
M /trunk/epan/dissectors/packet-isup.c
A fix for:
"ANSI ISUP Cause indicators with coding standard=ANSI fail to dissect."
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3654
------------------------------------------------------------------------
r28882 | stig | 2009-06-29 13:16:20 -0700 (Mon, 29 Jun 2009) | 2 lines
Changed paths:
M /trunk/packaging/Makefile.am
M /trunk/packaging/portableapps/win32
WiresharkPortable.ini -> WiresharkPortable.tmpl
------------------------------------------------------------------------
Update the release notes.
Directory: /trunk-1.2/epan/dfilter/
Changes Path Action
+17 -11 semcheck.c Modified
Directory: /trunk-1.2/epan/dissectors/
Changes Path Action
+3 -3 packet-isup.c Modified
+5 -0 packet-radius.c Modified
Directory: /trunk-1.2/docbook/
Changes Path Action
+25 -1 release-notes.xml Modified
Directory: /trunk-1.2/epan/
Changes Path Action
+0 -5 Makefile.nmake Modified
+0 -1 libwireshark.def Modified
+7 -3 radius_dict.l Modified
Directory: /trunk-1.2/gtk/
Changes Path Action
+17 -20 dfilter_expr_dlg.c Modified
Directory: /trunk-1.2/packaging/
Changes Path Action
+1 -1 Makefile.am Modified
