Wireshark-commits: [Wireshark-commits] rev 24643: /trunk/epan/ /trunk/epan/dissectors/: packet-acn.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: morriss@xxxxxxxxxxxxx
Date: Sat, 15 Mar 2008 22:42:06 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=24643

User: morriss
Date: 2008/03/15 10:42 PM

Log:
 From http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1539 :
 
 Hexadecimal and octal are unsigned.  Don't let dissectors register signed
 fields (FT_INT*) to be displayed in hexadecimal (including HEX_DEC and DEC_HEX)
 or octal.  Fix dissectors that do that mostly by changing the fields to
 unsigned though in PANA it appears the fields are meant to be signed so
 change those fields to be displayed in decimal.
 
 This fixes an assertion crash in hfinfo_numeric_format() if/when someone tries
 to create a filter using one of these mixed signed/unsigned fields (because
 that routine does not know how to present the user with a signed value in
 hex).
 
 Also add FT_*INT64 to the "make sure it's not BASE_NONE" check.

Directory: /trunk/epan/dissectors/
  Changes    Path                  Action
  +114 -114  packet-acn.c          Modified
  +51 -51    packet-dlm3.c         Modified
  +2 -2      packet-dua.c          Modified
  +7 -7      packet-ieee80211.c    Modified
  +2 -2      packet-pana.c         Modified
  +1 -1      packet-pcnfsd.c       Modified
  +351 -351  packet-ptp.c          Modified
  +36 -36    packet-scsi-ssc.c     Modified

Directory: /trunk/epan/
  Changes    Path          Action
  +21 -4     proto.c       Modified