Wireshark-commits: [Wireshark-commits] rev 24135: /trunk/gtk/ /trunk/gtk/: packet_list.c
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=24135
User: stig
Date: 2008/01/18 10:51 PM
Log:
I can't find any reason to unselect the current package only when an entry
in the packet details view is selected. I suppose unselecting the field is
more correct. The previous behaviour lead to some strange errors:
Select a packet and an entry in the packet details. Add a new column
and change a protocol preference. Observe the selected package is
unselected and packet 1 is selected, which I think is wrong.
Do the same as above with one of the following exceptions:
- without selecting an entry in the packet details.
- without adding a new column.
- without changing a protocol preference.
Observe the selected package is still selected, which is correct.
The correct behaviour here happens because of the cf_goto_frame call in
redraw_hex_dump_all, which causes the field to be unselected before
packet_list_set_sel_browse is called, and then the cf_unselect_package
is never called.
Maybe someone with a deeper knowledge should have a look at this...
Directory: /trunk/gtk/
Changes Path Action
+1 -1 packet_list.c Modified
