Wireshark · Wireshark-commits: [Wireshark-commits] rev 19210: /trunk/ /trunk/epan/dissectors/: packet-s5066.c /trunk/: AUTHORS

[sahlberg@xxxxxxxxxxxxx]

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=19210

User: sahlberg
Date: 2006/09/12 12:08 PM

Log:
 from Taner Kurtulus and Menno Andriesse
 
 Hi folks,
 We think we've found a bug in STANAG 5066 SIS layer dissector.
 
 Problem is at S_EXPEDITED_UNIDATA_INDICATION S_Prim's parser
 and occurs when we receive a U_PDU via expedited unidata channel.
 Dissector tries to parse first 2 bytes of U_PDU as a header size of  type
 21 s_prim (S_UNIDATA_INDICATION). But, this is not an wanted  process on
 that parser. Maybe, it was forgotten unchanged from
 S_UNIDATA_INDICATION dissector while copying it. So it shows
 data (U_PDU) 2 bytes short. Moreover, if data is just 1-byte, TCP datagrams
 receive TCP checksum error.
 
 
 Confirmed.
 
 It was indeed a "copy-paste-did not edit correctly" bug.
 
 While going over the code once more, I found:
 
 1 - One bug in the heuristic. (Changed '&&' to '||')
 2 - One to-do that was already done. (Removed the /* TODO */)
 3 - One to-do that is now done. ;-)

Directory: /trunk/epan/dissectors/
  Changes    Path              Action
  +83 -14    packet-s5066.c    Modified

Directory: /trunk/
  Changes    Path          Action
  +1 -0      AUTHORS       Modified