Wireshark-commits: [Wireshark-commits] rev 18530: /trunk/epan/dissectors/ /trunk/epan/dissectors/:
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: sahlberg@xxxxxxxxxxxxx
Date: Wed, 21 Jun 2006 09:45:52 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=18530

User: sahlberg
Date: 2006/06/21 09:45 AM

Log:
 two things have irritated me immensly with nfs filehandles
 
 
 1, (minor) the heuristics are too weak and everyting is always decoded either as netapp filehandles or one of the others   even when just capturing ibetween say two classic unix boxens
 2, (major) you can not filter on specific subfields of the filehandle
 
 
 observation: 5 people or less in the world care about implementation specific storage of data inside an opaque blob.
 
 
 remove the too weak heuristics for nfs filehandles.
 make decoding of filehandles accorrding to specific implementations controlled by a preference setting.
 default this setting to "unknown"
 
 display unknown filehandles using proto_tree_add_item()  FT_BYTES/BASE_HEX to make it fitlerable instead of a useless proto_tree_add_text()
 
 
 wiki needs to be updated tomorrow

Directory: /trunk/epan/dissectors/
  Changes    Path            Action
  +91 -149   packet-nfs.c    Modified
  +2 -0      packet-nfs.h    Modified