Wireshark-bugs: [Wireshark-bugs] [Bug 13264] WSLUA FileHandler causes crash (use-after-free) on
Comment # 4
on bug 13264
from Peter Wu
(In reply to Stig Bjørlykke from comment #3)
> (In reply to Peter Wu from comment #2)
> > I'll stash it on my to-do list for next year
>
> I have a initial patch which I can attach here for you to use as a starting
> point.
That can be helpful.
> One of the issues i had was with wtap_register_file_type_subtypes() and
> wtap_deregister_file_type_subtype() because this functions only disable and
> re-enable the entry based on the subtype (fh->file_type) value, which will
> be lost when reloading.
In meantime (?) Michael has also changed dissectors not to need deregistration
and Lua is now the only user of these routines. Maybe that makes it easier or
more difficult to implement the changes since you have some more freedom in the
API changes now, like actually removing registrations? (Beware of memory
hazards though.)
> I don't really know why the lua script should be able to disable itself
> with wslua_deregister_filehandler(). Maybe we could disable this feature,
> because that will make the reload implementation easier.
Remove it from the public Lua API? Might be a good idea, it is not tested
anywhere. I now see that it is already invoked during reloading of plugins,
something is possibly incomplete.
You are receiving this mail because:
- You are watching all bug changes.
