Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 11714] Tab navigation/Enter is not working in UAT dialogs

[bugzilla-daemon@xxxxxxxxxxxxx]

Peter Wu changed bug 11714

What	Removed	Added
CC		gerald@wireshark.org

Comment # 1 on bug 11714 from Peter Wu

Important issues that need to be fixed that currently cause crashes:

 - Validation of a full record after editing (see also other improvements
below).
 - Block OK button if an edited/added row is bad (*1).
   - As a special case, ignore newly added rows which were not modified
 - Prevent a removed row from being checked/used when the editor closes.

 (*1) do not do this for every existing item because of bug 7471? (people may
still want to add new entries even if the existing entries are bad, for example
due to a missing USB drive for filename fields?)

Other possible UX improvements:

 - On pressing Enter while Editing, the dialog should not close, only the
editor.
 - Likewise for pressing Escape while editing.
 - Color a full row if some field within the record is bad.
   - On selecting a cell, display its error message or the error message
     for other fields in the same record when the current cell is good.
   - Alternatively, when individual cells also get a highlight, just show
     the error message only when the cell is selected.
 - (minor) Stop editing when the field focus is gone? (click in empty area)
 - Allow resize of columns, the USER DLT UAT for example currently shows an
   ellipsis due to its use of a select menu which needs more space to fit.
 - Maybe it is also time to fix "Add drag reordering to UAT dialog".
 - Add one empty row that can be used to immediately add a new entry,
   suggested at http://ux.stackexchange.com/a/15637/91459
 - Currently, when the validation fails, the last input is used (e.g. if you
   type "ff" in a field that must be non-empty, then delete characters one by
   one, the last potentially valid input is used ("f")). This is not very
   intuitive.

The dialog looks inspired by the OS X user interface (+/- button, inline
editing). However the only example I could find was in the keyboard dialog
where you can add spelling corrections. In that dialog you can enter a word to
be matched (min. length 2) and a replacement word.

 - If you add a new entry and just enter one of the two fields, then change to
   a different tab and return, the new row is gone. (The row was invalid as one
   of the two fields was empty).
 - You can only add one new row at a time.
 - When adding a row, as long as some fields are not fully filled in, the
   record validation is not triggered (i.e. requiring min. length)
 - When editing an existing field, and the replacement word is cleared, a
   warning dialog is displayed after which the original contents is restored.
 - Interestingly, when a new, incomplete row (i.e. with only one field filled)
   exists, and an existing row is removed, then the new row is also gone.

Let's see if a sane UatModel can be designed. Resources:
https://doc.qt.io/qt-5/model-view-programming.html
https://doc.qt.io/qt-5/modelview.html

---

      You are receiving this mail because:

• You are watching all bug changes.