Wireshark-bugs: [Wireshark-bugs] [Bug 12687] SocketCAN dissector does not support CAN FD
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 01 Aug 2016 18:19:44 +0000

Comment # 11 on bug 12687 from 
(In reply to Gerrit Code Review from comment #4)

> The patch I created (https://code.wireshark.org/review/16787) is just a
> quick hack adding 0xD for CANFD.  Right now the canfd dissection is exactly
> the same as CAN.

In that patch you added:

void
proto_register_socketcanfd(void)
{
       proto_can = proto_register_protocol("Controller Area Network FD",
"CANFD", "canfd");
       canfd_handle = register_dissector("canfd", dissect_socketcanfd,
proto_canfd);
}

Should it be "proto_canfd = ..." instead of "proto_can = ..." in this function?

You are receiving this mail because:
  • You are watching all bug changes.