Wireshark-bugs: [Wireshark-bugs] [Bug 12676] Dissector bug, protocol CIP: C:\buildbot\wireshark
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 28 Jul 2016 12:30:36 +0000

changed bug 12676


What Removed Added
CC   pascal.quantin@gmail.com

Comment # 2 on bug 12676 from 
The assert is due to my change I44cb3ce8e647ae2816d5ffa95435068c435a1e5c
because the CIP dissector calls proto_tree_add_subtree() with a NULL tvb
pointer...
Now that we are checking the validity of the length given, this call becomes
invalid.
I could skip the bound checks if no tvb is being given but the current code
seems wrong in the first place.
I propose to keep the bound checks as is and fix CIP dissector. Is it OK? Or
should we skip the bound checks in that case?

You are receiving this mail because:
  • You are watching all bug changes.