Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8859] Apply consistent naming convention to checksum display filter fields and

[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 8 on bug 8859 from Michael Mann

(In reply to Gerrit Code Review from comment #7)
> Change 16380 had a related patch set uploaded by Michael Mann:
> Add proto_tree_add_checksum.
> 
> https://code.wireshark.org/review/16380

This is a "ping" because not all dissectors were addressed.  I have 2 remaining
categories:

1. Checksums that are a byte array field
packet-aruba-papi.c
packet-bfd.c
packet-dcc.c
packet-negoex.c
packet-rpc.c
packet-spnego.c
packet-wccp.c


2. Checksum fields that didn't fit into the proto_tree_add_bitmask signature
provided.  Maybe adding more "flags" would suffice, but most probably mean a
new API (to handle comparison of checksum).  Some also may have just been
difficult in trying to convert.

packet-btle.c
packet-cimd.c
packet-fix.c
packet-flip.c - checksum is bitmasked
packet-gfp.c
packet-ipmi.c
packet-iuup.c
packet-mux27010.c
packet-opensafety.c
packet-ospf.c
packet-p_mul.c
packet-rsvp.c - need placeholder?  Okay with checksum at end of packet?
packet-umts_fp.c
packet-rfid-pn532-hci.c


There will also be a "follow up" patch that will fill in some of the "status
fields" and "expert info" for dissectors that don't already have them.

---

      You are receiving this mail because:

• You are watching all bug changes.