Wireshark-bugs: [Wireshark-bugs] [Bug 12419] Upgraded to ver 2.0.3 but now the telephony callflo
Comment # 5
on bug 12419
from Gerald Combs
(In reply to Mike from comment #0)
> When that window pops up with the selected SIP packets, there is no headers
> (ie Time Comment) there is no colors and most annoyingly there is no
> ability to resize the fields/columns.
>
> All this was present in my previous build and made looking at callflows very
> easy and usable. Now it is not or looks like a budget version.
>
> Has something been changed on purpose ? I am considering trying to
> re-install an older version because this version is not usable for me.
>
> Nothing has changed on my windows 8.1 machine.
>
> I have attached a snapshot but removed / erased the phone number's and
> network addresses on the right.
There are a few places where the Qt UI still needs to catch up to the GTK+ UI.
The flow / sequence dialog is one of them. Change 15554 adds the Time and
Comment headers and colors to the Qt UI. Change 15559 improves navigation
(which you didn't mention but needed to be fixed nonetheless).
We probably won't be able to make the Qt columns resizable any time soon (see
below). In the mean time, the complete comment should show up in the hint area
when you hover over an item.
(In reply to Guy Harris from comment #2)
> OK, the fix for bug 11710 may have fixed the code to put the columns in
> question into the dialog - but, unlike the GTK+ UI, the Qt UI doesn't put
> headings above the columns.
>
> In addition, the middle pane showing the flow diagram is cut off on the left
> by the column showing the relative time stamps, and, whilst the middle pane
> is green in the GTK+ version, it's colorless in the Qt version - I don't
> know if those are packet colors or not (there's only one color, green, in
> the capture I used to test this).
Fixed in change 15554. The colors come from a static table defined in
ui/gtk/graph_analysis.c. I copied it to ui/qt.
> The GTK+ version has 3 real columns, with separators and headers, and the
> separators can be dragged to change the column widths; the Qt version
> doesn't have them.
The GTK+ UI creates 3 Cairo surfaces and draws directly to them. The Qt UI uses
a single QCustomPlot with axes for the time, address, and comment strings. This
makes it trivial to add PDF and PNG export and provide hover feedback, but QCP
doesn't provide an obvious way to resize axes.
To make the columns resizable in the Qt UI we could do one of the following:
- Split the time, diagram, and comment sections into three separate widgets
inside a QSplitter. This would resemble the GTK+ UI, but we'd have to
coordinate between the three and we'd lose time and comment values in PDF and
PNG exports.
- Add separate controls for the width and/or visibility of the Time and Comment
columns.
- Fake a splitter widget by catching mouse events in the plot area.
For the Time column in particular, what's the use case for making it resizable?
How useful is half a timestamp?
You are receiving this mail because:
- You are watching all bug changes.
