Wireshark-bugs: [Wireshark-bugs] [Bug 11719] wireshark-gtk coredumps on redissection ("Decode As
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 18 Nov 2015 18:46:26 +0000

Comment # 10 on bug 11719 from 
(In reply to Stig Bjørlykke from comment #9)
> (In reply to Gerrit Code Review from comment #7)
> > Change 11943 had a related patch set uploaded by Gerald Combs:
> > Revert: Free cf->edt before free cf->epan when redissecting.
> > 
> > https://code.wireshark.org/review/11943
> 
> This does not fix the Qt UI issues I have.
> 
> I'm getting a crash when updating a protocol preference by second-click the
> packet in the tree view and selecting something which triggers a redissect. 
> The crash happens in setMenusForSelectedTreeRow() line 1268 where edt->pi is
> released memory.
> 
> To reproduce:
> From https://wiki.wireshark.org/SampleCaptures download dmp-examples.pcap
> and configure DMP to use port 24209.  Select the first packet, second-click
> on DMP in the tree view and change "National decoding".  This will trigger a
> "Use of deallocated memory detected" if running with AddressSanitizer / ASAN.
> 
> I'll investigate some more.

I'm having trouble duplicating the crash, but would changing line 1268 to 

if (capture_file_.capFile() && !capture_file_.capFile()->redissecting &&
capture_file_.capFile()->edt) {

help?

You are receiving this mail because:
  • You are watching all bug changes.