Wireshark-bugs: [Wireshark-bugs] [Bug 11347] Text for GSM H/L flags is not correct
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 08 Jul 2015 13:51:48 +0000

Comment # 9 on bug 11347 from 
(In reply to Pascal Quantin from comment #6)
> (In reply to Jean Thomas from comment #4)
> > (In reply to Pascal Quantin from comment #3)
> > > Regarding the patch itself, you can combine
> > > proto_tree_add_boolean+proto_item_prepend_text calls by
> > > proto_tree_add_boolean_format I think.
> > 
> > I tried and I think that it's not possible: the True/False string are not
> > used by proto_tree_add_boolean_format
> 
> proto_tree_add_boolean_format gives you full control of the output. it means
> that you must do it yourself with a code like TRUE ? tfstring->true_string :
> tfstring->false_string
> 
> At the end it will end up being bigger (uglier ?) code than yours...

Yes, I had created a new function using proto_tree_add_boolean_format and
tfstring->true/false_string, but I found it uglier than the code I provided in
the patch. 
I find it better to reuse the existing functions, even if it means 2 method
calls instead of one.

You are receiving this mail because:
  • You are watching all bug changes.