Wireshark-bugs: [Wireshark-bugs] [Bug 11331] Error recognizing http2 traffic
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 06 Jul 2015 19:45:35 +0000

Comment # 3 on bug 11331 from 
(In reply to Peter Wu from comment #2)
> I just checked the capture and HTTP2 is somehow layered above http:
> 
> In change 7782 you proposed:
> 
> > We could have the HTTP dissector check if a conversation data exists 
> > for HTTP2 and call the dissector accordingly, like what we are doing 
> > in case of HTTP2 upgrade (in dissect_http() function. What do you 
> > think?
> 
> That seems good to me (eliminating the HTTP layer if HTTP2 is detected),
> will it still work with Decode As though? Consider a HTTP/1.1
> request/response with a binary file download that begins with the HTTP2
> magic sequence.

With my proposal, you do not eliminate the HTTP dissector call, but instead
calls early in the HTTP dissection the HTTP2 dissector. So with 'Decode As'
functionality, you cannot force it to HTTP as the heuristic dissector still
kicks in. I *think * this was still the case prior to the change done in 
https://code.wireshark.org/review/#/c/7782

You are receiving this mail because:
  • You are watching all bug changes.